Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Tabs component documentation #1953

Merged
merged 6 commits into from
Dec 15, 2020

Conversation

jessmetivier
Copy link
Contributor

@jessmetivier jessmetivier commented Dec 9, 2020

Description

  • update tabs documentation

@netlify
Copy link

netlify bot commented Dec 9, 2020

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: 3ecd41d

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5fd8fa329dc35e00078619d5

😎 Browse the preview: https://deploy-preview-1953--fundamental-styles.netlify.app

@jessmetivier jessmetivier changed the title [WIP] docs: update tabs documentation docs: update tabs documentation Dec 11, 2020
@jessmetivier jessmetivier requested a review from a team December 11, 2020 19:44
@jessmetivier jessmetivier self-assigned this Dec 11, 2020
@jessmetivier jessmetivier added the Doc website documentation website label Dec 11, 2020
@jessmetivier jessmetivier added this to the Sprint 52 - Hilo milestone Dec 11, 2020
storyDescription: 'Standard Tabs with `nav` element'
docs: {
iframeHeight: 300,
storyDescription: `Tabs can display icons instead of text with the \` fd-tabs__icon\` class. In addition, add the \`fd-tabs--icon-only\` class to the main element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should state the reason we are adding to the main element

@InnaAtanasova InnaAtanasova changed the title docs: update tabs documentation docs: update Tabs component documentation Dec 15, 2020
@InnaAtanasova InnaAtanasova merged commit 6ba59c4 into master Dec 15, 2020
@InnaAtanasova InnaAtanasova deleted the docs/update-tabs-documentation branch December 15, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc website documentation website
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants