docs: update Time component documentation #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for fundamental-styles ready! 🔨 Explore the source changes: 0397051 🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5fd90a84ddf93d00082843ef 😎 Browse the preview: https://deploy-preview-1959--fundamental-styles.netlify.app |
jessmetivier
changed the title
stefanoScalzo
approved these changes
Dec 14, 2020
JKMarkowski
reviewed
Dec 15, 2020
stories/time/time.stories.js
Outdated
| 'Default cozy mode implemented mostly to be used mobile devices. There should be at most 1 active wrapper, marked with <code class="docs-code">fd-time__wrapper--active</code> modifier. In those examples it\'s hour or meridian. The rest of items should be marked as collapsed <code class="docs-code">fd-time__item--collapsed</code>. Also meridian (AM/PM) wrapper has to contain <code class="docs-code">fd-time__wrapper--meridian</code> modifier.' | ||
| storyDescription: `The default time component is displayed in cozy mode, which is ideal for mobile screens. | ||
|
|
||
| Only one item and wrapper should be active at a time with the \`fd-timewrapper--active\` modifier class. The rest of the items must be collapsed with the \`fd-timeitem--collapsed\` modifier class, displaying only the collapsed slider item (blue) next to the active item. |
There was a problem hiding this comment.
Could you change fd-timewrapper--active to fd-time__wrapper--active?
stories/time/time.stories.js
Outdated
|
|
||
| Only one item and wrapper should be active at a time with the \`fd-timewrapper--active\` modifier class. The rest of the items must be collapsed with the \`fd-timeitem--collapsed\` modifier class, displaying only the collapsed slider item (blue) next to the active item. | ||
|
|
||
| **Note:** The meridian (AM/PM) wrapper must contain the \`fd-timewrapper--meridian\` modifier class. |
There was a problem hiding this comment.
Could you change fd-timewrapper--meridian to fd-time__wrapper--meridian?
InnaAtanasova
changed the title
…AP/fundamental-styles into docs/update-time-documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
{{ Updated Time docs. }}