fix: outline color of breakcrumb icon overflow #1969
Conversation
|
✔️ Deploy preview for fundamental-styles ready! 🔨 Explore the source changes: 7956807 🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5fda14ebd6d2d500075183b9 😎 Browse the preview: https://deploy-preview-1969--fundamental-styles.netlify.app |
stefanoScalzo
force-pushed
the
fix-breadcrumb-hover
branch
from
4f17e4b
to
9769716
Compare
src/breadcrumb.scss
Outdated
| .#{$block}__dropdown-icon { | ||
| color: var(--sapLink_Active_Color, #0a6ed1); | ||
| } | ||
| } | ||
|
|
||
| &:active { | ||
| .#{$block}__dropdown-icon { | ||
| color: var(--sapLink_Active_Color, #0a6ed1); | ||
| } | ||
|
|
||
| &:hover { | ||
| .#{$block}__dropdown-icon { | ||
| color: var(--sapLink_Active_Color, #0a6ed1); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| &:hover { | ||
| .#{$block}__dropdown-icon { | ||
| color: var(--sapLink_Hover_Color, #0854a0); |
There was a problem hiding this comment.
Why are you adding the colors this way?
Should be just color: var(--sapLink_Hover_Color); or `color: var(--sapLink_Active_Color)
There was a problem hiding this comment.
and since var(--sapLink_Active_Color) is repeated 3 times maybe put it in a variable.
There was a problem hiding this comment.
I noticed we have fallbacks in some components but ill change it :)
There was a problem hiding this comment.
That's not the proper way to add a fallback in general. You will need:
color: #0854a0;
color: var(--sapLink_Hover_Color, #0854a0);
There was a problem hiding this comment.
Also, I searched the project and couldn't find such case :)
There's one usage in custom.scss file which is for the documentation. I think you are talking about fundamental-ngx, but this is another case.
Related Issue
Closes #1892
Description
Make all states have the same color for both items
Screenshots
Before:
After:
Please check whether the PR fulfills the following requirements
remfd-*class is used in the filefd-rtl,fd-ellipsis,fd-flex,fd-selected,fd-focus, ect.)fd-reset()mixin is applied to all elementsnormalizeoptionunnormalizeoption