Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update form grid documentation #1979

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

jessmetivier
Copy link
Contributor

@jessmetivier jessmetivier commented Dec 16, 2020

Description

{{ Updated Form Grid docs. }}

Comment: I think it's best to remove the last example, since we shouldn't be providing an example of layouts that are unrecommended. Instead, I would like to add a note that advises against them in the "Recommended layouts" example.

@jessmetivier jessmetivier self-assigned this Dec 16, 2020
@jessmetivier jessmetivier added the Doc website documentation website label Dec 16, 2020
@jessmetivier jessmetivier requested a review from a team December 16, 2020 21:14
@jessmetivier jessmetivier changed the title updated-docs [WIP] docs: updated form grid documentation Dec 16, 2020
@netlify
Copy link

netlify bot commented Dec 16, 2020

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: 197cb97

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5fdbc3760c8309000747eb8c

😎 Browse the preview: https://deploy-preview-1979--fundamental-styles.netlify.app

@JKMarkowski JKMarkowski changed the base branch from master to main December 17, 2020 10:52
@jessmetivier jessmetivier changed the title [WIP] docs: updated form grid documentation docs: updated form grid documentation Dec 17, 2020
@InnaAtanasova InnaAtanasova changed the title docs: updated form grid documentation docs: update Form Grid documentation Dec 17, 2020
@jessmetivier jessmetivier changed the title docs: update Form Grid documentation docs: update form grid documentation Dec 17, 2020
@InnaAtanasova InnaAtanasova force-pushed the docs/update-formgrid-documentation branch from 70c1e46 to 197cb97 Compare December 17, 2020 20:45
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droshev droshev added this to the Sprint 52 - Hilo milestone Jan 3, 2021
@droshev droshev self-requested a review January 4, 2021 01:13
@droshev droshev merged commit fca369e into main Jan 4, 2021
@droshev droshev deleted the docs/update-formgrid-documentation branch January 4, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc website documentation website
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants