Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add delta theming for Forms #1996

Merged
merged 3 commits into from
Jan 4, 2021
Merged

fix: add delta theming for Forms #1996

merged 3 commits into from
Jan 4, 2021

Conversation

katekozlowska
Copy link
Contributor

Related Issue

Part of #1357

Description

Add theming deltas for Forms

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • N/A All values are in rem
  • N/A Text elements follow the truncation rules
  • N/A hover state of the element follow design spec
  • N/A focus state of the element follow design spec
  • N/A active state of the element follow design spec
  • N/A selected state of the element follow design spec
  • N/A selected hover state of the element follow design spec
  • N/A pressed state of the element follow design spec
  • N/A Responsiveness rules - the component has modifier classes for all breakpoints
  • N/A Includes Compact/Cosy/Tablet design
  • N/A RTL support
  1. The code follows fundamental-styles code standards and style
  • N/A BEM naming convention is used
  • N/A Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • N/A A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • N/A fd-reset() mixin is applied to all elements
  • N/A Variables are used, if some value is used more than twice.
  • N/A Checked if current components can be reused, instead of having new code.
  1. Testing
  • N/A tested Storybook examples with "CSS Resources" normalize option
  • N/A tested Storybook examples with "CSS Resources" unnormalize option
  • N/A Verified all styles in IE11
  • N/A Updated tests
  1. Documentation
  • N/A Storybook documentation has been created/updated
  • N/A Breaking Changes wiki has been updated in case of breaking changes.

@netlify
Copy link

netlify bot commented Dec 28, 2020

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: 129f92c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5fea3d020584af0008ed623c

😎 Browse the preview: https://deploy-preview-1996--fundamental-styles.netlify.app

Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katekozlowska why did you comment all the points on PR with N/A

Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JKMarkowski JKMarkowski added this to the Sprint 52 - Hilo milestone Jan 4, 2021
Copy link
Contributor

@stefanoScalzo stefanoScalzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droshev droshev self-requested a review January 4, 2021 17:00
@droshev droshev merged commit 5ba3859 into main Jan 4, 2021
@droshev droshev deleted the fix/delta-forms branch January 4, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants