Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkbox label for required #1998

Merged
merged 2 commits into from
Jan 8, 2021
Merged

fix: checkbox label for required #1998

merged 2 commits into from
Jan 8, 2021

Conversation

stefanoScalzo
Copy link
Contributor

@stefanoScalzo stefanoScalzo commented Dec 29, 2020

Related Issue

Closes #883

Description

Fixes the positioning of the required label

Screenshots

Before:

image

After:

Screen Shot 2020-12-29 at 3 44 16 PM

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@stefanoScalzo stefanoScalzo added the Bug Something isn't working label Dec 29, 2020
@stefanoScalzo stefanoScalzo added this to the Sprint 52 - Hilo milestone Dec 29, 2020
@stefanoScalzo stefanoScalzo requested a review from a team December 29, 2020 20:45
@stefanoScalzo stefanoScalzo self-assigned this Dec 29, 2020
@netlify
Copy link

netlify bot commented Dec 29, 2020

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: 7a956c8

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5ff32f760c0721000714b57f

😎 Browse the preview: https://deploy-preview-1998--fundamental-styles.netlify.app

Comment on lines 100 to 101
<input type="checkbox" class="fd-checkbox fd-checkbox--compact" id="Ai4ez611c">
<label class="fd-form-label--required fd-checkbox__label fd-checkbox__label--compact" for="Ai4ez611c">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change id/for ? It seems to be duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mikerodonnell89 mikerodonnell89 merged commit f5baca7 into main Jan 8, 2021
@mikerodonnell89 mikerodonnell89 deleted the fix-checkbox-label branch January 8, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

checkbox & radio: required class (with asterisk) is missing
4 participants