fix: add delta theming for Generic Tiles #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for fundamental-styles ready! 🔨 Explore the source changes: 82dcf40 🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5ffc513ab25efa0007554efb 😎 Browse the preview: https://deploy-preview-2017--fundamental-styles.netlify.app |
InnaAtanasova
force-pushed
the
chore/delta-theming-tiles
branch
3 times, most recently
from
6334d88
to
3f5aa03
Compare
droshev
approved these changes
Jan 7, 2021
InnaAtanasova
changed the title
InnaAtanasova
force-pushed
the
chore/delta-theming-tiles
branch
from
3f5aa03
to
82dcf40
Compare
mikerodonnell89
approved these changes
Jan 12, 2021
InnaAtanasova
changed the title
InnaAtanasova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Part of #1357
Description
The current PR adds the delta theming for Generic Tiles. Changed values: in Slide Tile - the container background and the opacity, the dot sizes and colors, as well as the spacing between them.
This PR can be merged after the designers confirm the colors as it looks like something is off:
Element A - Transparent background layer on tile image. Has
background-color: --sapBlockLayer_Backgroundwhich results in #000000 in Quartz Light. It has opacity 0.85Element B - title and subtitle area. The title (text) has color
--sapTile_TitleTextColorwhich results in #32363A. The subtitle has--sapTile_TextColorwhich results in #6A6D70. The final result in Quartz Light is a dark grey text on black background with 0.85 opacity.Text-shadow for HCW looks weird
Screenshots
Quartz Light:
Quartz Dark:
HCW:
HCB:
Please check whether the PR fulfills the following requirements
NA
NA
NA
NA