Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add delta theming for Link #2018

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Part of #1357

Description

Adds delta theming for Link.

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • [na] All values are in rem
  • [na] Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • [na] Responsiveness rules - the component has modifier classes for all breakpoints
  • [na] Includes Compact/Cosy/Tablet design
  • [na] RTL support
  1. The code follows fundamental-styles code standards and style
    NA
  2. Testing
    NA
  3. Documentation
    NA

@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: 977f9a6

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5ff73bdcce38bb000792cbe4

😎 Browse the preview: https://deploy-preview-2018--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova force-pushed the chore/delta-theming-link branch 2 times, most recently from a241d18 to 5cc2a1f Compare January 6, 2021 15:48
@InnaAtanasova InnaAtanasova changed the title chore: add delta theming for Link fix: add delta theming for Link Jan 7, 2021
@InnaAtanasova InnaAtanasova merged commit a445585 into main Jan 7, 2021
@InnaAtanasova InnaAtanasova deleted the chore/delta-theming-link branch January 7, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants