Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Dynamic Page default scrollbar appearing in IE #2044

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

kavya-b
Copy link
Contributor

@kavya-b kavya-b commented Jan 12, 2021

Related Issue

Closes #2043

Description

This PR fixes the incorrect scrollbar appearing in dynamic page content area. This scrollbar should not have appeared at all since content is fitting well within the page. It also fixes the issue where 2 scrollbars appear when content does not fit the page. Verified in IE.

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

Before:

Screenshot 2021-01-12 at 10 15 10 AM

After:

Screenshot 2021-01-12 at 10 14 55 AM

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  1. Documentation
  • Storybook documentation has been created/updated
  • [n/a] Breaking Changes wiki has been updated in case of breaking changes.

@kavya-b kavya-b added Bug Something isn't working Defect Hunting ariba sap ariba team labels Jan 12, 2021
@kavya-b kavya-b added this to the Sprint 54 - Ariba milestone Jan 12, 2021
@kavya-b kavya-b requested a review from a team January 12, 2021 06:03
@kavya-b kavya-b self-assigned this Jan 12, 2021
@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: 6b06474

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5ffd3ba353f1db00090d097b

😎 Browse the preview: https://deploy-preview-2044--fundamental-styles.netlify.app

@kavya-b kavya-b requested a review from a team January 12, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ariba sap ariba team Bug Something isn't working Defect Hunting
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Dynamic Page - wrong scroll areas
3 participants