Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: multi input markup update #2048

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Jan 13, 2021

Related Issue

part of #2045

Description

There is new multi input markup relied on selection list. Because it looks same, so there is no reason to have 2 different htmls

Please check whether the PR fulfills the following requirements

  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@JKMarkowski JKMarkowski added this to the Sprint 53 - Canggu milestone Jan 13, 2021
@JKMarkowski JKMarkowski requested a review from a team January 13, 2021 13:20
@JKMarkowski JKMarkowski self-assigned this Jan 13, 2021
@netlify
Copy link

netlify bot commented Jan 13, 2021

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: e6a5661

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5ffef3a967524c00084a4f1f

😎 Browse the preview: https://deploy-preview-2048--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova merged commit 477b456 into main Jan 14, 2021
@InnaAtanasova InnaAtanasova deleted the docs/multi-input-markup-update branch January 14, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants