docs: button docs improvements #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for fundamental-styles ready! 🔨 Explore the source changes: 0b5cf99 🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/600064ccba41f40007efb499 😎 Browse the preview: https://deploy-preview-2054--fundamental-styles.netlify.app |
6 tasks
InnaAtanasova
requested changes
Jan 13, 2021
| @@ -286,6 +286,15 @@ code.docs-code-grey { | |||
| background-color: #f8f8f8; | |||
| } | |||
|
|
|||
| .fddocs-button-container { | |||
There was a problem hiding this comment.
Won't this work if you apply it on the fddocs-container without adding additional class? And prob should be fd-docs-container?
There was a problem hiding this comment.
fddocs-container was already in place so I just kept it, and I only want to apply it to buttons in this example, not everywhere, and fddocs-container is used throughout the examples
|
For me it works fine, but not for split button, which I guess has stronger selector: |
InnaAtanasova
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2045
Improves the look of button docs