Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change the icon of the button showing/hiding the second level of Side Nav #2055

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Part of #2045

Description

Add JS to the documentation for changing the icon of the button responsible for opening/hiding the second level of the Side navigation

Screenshots

Before:

Screen Shot 2021-01-13 at 3 11 12 PM

After:

Screen Shot 2021-01-13 at 3 10 12 PM

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
    NA
  2. The code follows fundamental-styles code standards and style
    NA
  3. Testing
  • [na] tested Storybook examples with "CSS Resources" normalize option
  • [na] tested Storybook examples with "CSS Resources" unnormalize option
  • [na] Verified all styles in IE11
  • Updated tests
  1. Documentation
  • Storybook documentation has been created/updated
  • [na] Breaking Changes wiki has been updated in case of breaking changes.

@InnaAtanasova InnaAtanasova added this to the Sprint 53 - Canggu milestone Jan 13, 2021
@InnaAtanasova InnaAtanasova requested a review from a team January 13, 2021 20:11
@InnaAtanasova InnaAtanasova self-assigned this Jan 13, 2021
@InnaAtanasova InnaAtanasova mentioned this pull request Jan 13, 2021
6 tasks
@netlify
Copy link

netlify bot commented Jan 13, 2021

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: 02813bc

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5fff5b5420df240007066d60

😎 Browse the preview: https://deploy-preview-2055--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova merged commit bb48e35 into main Jan 14, 2021
@InnaAtanasova InnaAtanasova deleted the fix/nested-list-button branch January 14, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants