Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add fix for contextual menu not showing in Table example #2056

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Part of #2045

Description

The contextual menus in Table example were not showing on button click. Updated the documentation to use onPopoverClick function

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
    NA
  2. The code follows fundamental-styles code standards and style
    NA
  3. Testing
  • [na] tested Storybook examples with "CSS Resources" normalize option
  • [na] tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  1. Documentation
  • Storybook documentation has been created/updated
  • [na] Breaking Changes wiki has been updated in case of breaking changes.

@InnaAtanasova InnaAtanasova added this to the Sprint 53 - Canggu milestone Jan 13, 2021
@InnaAtanasova InnaAtanasova requested a review from a team January 13, 2021 21:02
@InnaAtanasova InnaAtanasova self-assigned this Jan 13, 2021
@InnaAtanasova InnaAtanasova mentioned this pull request Jan 13, 2021
6 tasks
@netlify
Copy link

netlify bot commented Jan 13, 2021

✔️ Deploy preview for fundamental-styles ready!

🔨 Explore the source changes: be46966

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-styles/deploys/5fff5ff3fc9b3300076e51f8

😎 Browse the preview: https://deploy-preview-2056--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova merged commit 83f7c25 into main Jan 14, 2021
@InnaAtanasova InnaAtanasova deleted the docs/contextual-menu-table-bug branch January 14, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants