Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Semantic tabs color #2162

Merged
merged 1 commit into from Feb 26, 2021
Merged

fix: Semantic tabs color #2162

merged 1 commit into from Feb 26, 2021

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Feb 23, 2021

Related Issue

part of #2161

Description

There are added some selectors into tabs component, to make semantic mode work properly

Screnshots

Before:
image
After:
image

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@JKMarkowski JKMarkowski added this to the Sprint 56 - Galway milestone Feb 23, 2021
@JKMarkowski JKMarkowski requested a review from a team February 23, 2021 12:19
@JKMarkowski JKMarkowski self-assigned this Feb 23, 2021
@netlify
Copy link

netlify bot commented Feb 23, 2021

Deploy preview for fundamental-styles ready!

Built with commit b075853

https://deploy-preview-2162--fundamental-styles.netlify.app

@InnaAtanasova
Copy link
Contributor

@JKMarkowski please check the UI Tests. You prob need to rebase main

@JKMarkowski JKMarkowski merged commit f13a7c2 into main Feb 26, 2021
@JKMarkowski JKMarkowski deleted the fix/tabs-semantic branch February 26, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants