Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update object status large font-family [ci visual] #2168

Merged
merged 1 commit into from Feb 27, 2021

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Feb 27, 2021

Related Issue

fixes #2164

Description

specify font-family for large object status

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])

@droshev droshev added Fiori 3 refactoring match Fiori 3 requirements denoland Issue will be handled/done by the Denoland team labels Feb 27, 2021
@droshev droshev added this to the Sprint 57 - Edinburgh milestone Feb 27, 2021
@droshev droshev requested a review from a team February 27, 2021 23:12
@droshev droshev self-assigned this Feb 27, 2021
@netlify
Copy link

netlify bot commented Feb 27, 2021

Deploy preview for fundamental-styles ready!

Built with commit 16575a1

https://deploy-preview-2168--fundamental-styles.netlify.app

@droshev droshev merged commit f9d4349 into main Feb 27, 2021
@droshev droshev deleted the fix/update-obj-status-large-font branch February 27, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
denoland Issue will be handled/done by the Denoland team Fiori 3 refactoring match Fiori 3 requirements
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Bug: incorrect font-family value for Object Status Large Design
2 participants