Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add alignment and focus related fixes for Shellbar #2179

Merged
merged 4 commits into from Mar 4, 2021

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Mar 3, 2021

Related Issue

Part of SAP/fundamental-ngx#4822 (NGX)

Description

  • add example of Shellbar with Side Nav control button aka hamburger menu
  • add proper alignment for the button (spacing)
  • add fix for the focus color of the buttons used inside Shellbar, including Product Switch toggle

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

Before:

Screen Shot 2021-03-03 at 5 13 24 PM

Screen Shot 2021-03-03 at 5 13 15 PM

After:

Screen Shot 2021-03-03 at 5 12 23 PM

Screen Shot 2021-03-03 at 5 12 15 PM

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@InnaAtanasova InnaAtanasova added this to the Sprint 57 - Edinburgh milestone Mar 3, 2021
@InnaAtanasova InnaAtanasova requested a review from a team March 3, 2021 22:14
@InnaAtanasova InnaAtanasova self-assigned this Mar 3, 2021
@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for fundamental-styles ready!

Built with commit 1b5217d

https://deploy-preview-2179--fundamental-styles.netlify.app

Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@InnaAtanasova InnaAtanasova merged commit 657329a into main Mar 4, 2021
@InnaAtanasova InnaAtanasova deleted the fix/shellbar-dxp-issues branch March 4, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants