Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: components in active table rows #2186

Merged
merged 2 commits into from Mar 6, 2021
Merged

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Mar 5, 2021

Related Issue

fixes #2182
fixes #2183
fixes #2184
fixes #2185

Description

apply the right color on components in an active table cell

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • active state of the element follow design spec
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated

@droshev droshev requested a review from a team March 5, 2021 20:29
@droshev droshev force-pushed the fix/elements-in-active-table-rows branch from e67aef0 to 007eca9 Compare March 5, 2021 20:30
@netlify
Copy link

netlify bot commented Mar 5, 2021

Deploy preview for fundamental-styles ready!

Built with commit e67aef0

https://deploy-preview-2186--fundamental-styles.netlify.app

@droshev droshev self-assigned this Mar 5, 2021
@droshev droshev added the Fiori 3 refactoring match Fiori 3 requirements label Mar 5, 2021
@droshev droshev added this to the Sprint 57 - Edinburgh milestone Mar 5, 2021
@netlify
Copy link

netlify bot commented Mar 5, 2021

Deploy preview for fundamental-styles ready!

Built with commit 958d914

https://deploy-preview-2186--fundamental-styles.netlify.app

@droshev droshev merged commit c6e9d52 into main Mar 6, 2021
@droshev droshev deleted the fix/elements-in-active-table-rows branch March 6, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fiori 3 refactoring match Fiori 3 requirements
Projects
Development
  
Awaiting triage
2 participants