Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add fix for Dynamic Page title alignment issues #2188

Merged
merged 2 commits into from Mar 10, 2021
Merged

fix: add fix for Dynamic Page title alignment issues #2188

merged 2 commits into from Mar 10, 2021

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Mar 8, 2021 •
edited by droshev

Related Issue

Portal related issue

Description

The elements in the Title container of Dynamic Page were not aligned vertically due to padding top added to the title and items being aligned baseline.

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

Before:

Screen Shot 2021-03-08 at 3 17 06 PM

Screen Shot 2021-03-08 at 3 16 44 PM

Screen Shot 2021-03-08 at 3 15 41 PM

Screen Shot 2021-03-08 at 3 16 24 PM

After:

Screen Shot 2021-03-08 at 3 14 40 PM

Screen Shot 2021-03-08 at 3 14 15 PM

Screen Shot 2021-03-08 at 3 13 41 PM

Screen Shot 2021-03-08 at 3 18 51 PM

@InnaAtanasova InnaAtanasova added this to the Sprint 57 - Edinburgh milestone Mar 8, 2021
@InnaAtanasova InnaAtanasova requested a review from a team March 8, 2021 20:19
@InnaAtanasova InnaAtanasova self-assigned this Mar 8, 2021
@netlify
Copy link

netlify bot commented Mar 8, 2021 •
edited

Deploy preview for fundamental-styles ready!

Built with commit 4dd4ee0

https://deploy-preview-2188--fundamental-styles.netlify.app

kavya-b
kavya-b approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@kavya-b kavya-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JKMarkowski
JKMarkowski approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - now it will look better, even on various cozy/compact modes mixed with small/large

@InnaAtanasova InnaAtanasova merged commit e866047 into main Mar 10, 2021
@InnaAtanasova InnaAtanasova deleted the fix/dynamic-page-alignment-issues branch March 10, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKMarkowski JKMarkowski JKMarkowski approved these changes

@kavya-b kavya-b kavya-b approved these changes

Assignees

@InnaAtanasova InnaAtanasova

Labels
dxp
Projects
Development
  
Awaiting triage
Milestone
Sprint 57 - Edinburgh
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@InnaAtanasova @JKMarkowski @kavya-b