Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary code form table.scss #2199

Merged
merged 1 commit into from Mar 16, 2021

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Mar 15, 2021

Description

There is some code, that is unnecesary, needs to be removed

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • [NA] All values are in rem
  • [NA] Text elements follow the truncation rules
  • [NA] hover state of the element follow design spec
  • [NA] focus state of the element follow design spec
  • [NA] active state of the element follow design spec
  • [NA] selected state of the element follow design spec
  • [NA] selected hover state of the element follow design spec
  • [NA] pressed state of the element follow design spec
  • [NA] Responsiveness rules - the component has modifier classes for all breakpoints
  • [NA] Includes Compact/Cosy/Tablet design
  • [NA] RTL support
  1. The code follows fundamental-styles code standards and style
  • [NA] only one top level fd-* class is used in the file
  • [NA] BEM naming convention is used
  • [NA] Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • [NA] A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • [NA] fd-reset() mixin is applied to all elements
  • [NA] Variables are used, if some value is used more than twice.
  • [NA] Checked if current components can be reused, instead of having new code.
  1. Testing
  • [NA] tested Storybook examples with "CSS Resources" normalize option
  • [NA] tested Storybook examples with "CSS Resources" unnormalize option
  • [NA] Verified all styles in IE11
  • [NA] Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • [NA] Storybook documentation has been created/updated
  • [NA] Breaking Changes wiki has been updated in case of breaking changes.

@JKMarkowski JKMarkowski requested a review from a team March 15, 2021 17:00
@JKMarkowski JKMarkowski self-assigned this Mar 15, 2021
@JKMarkowski JKMarkowski added this to the Sprint 57 - Edinburgh milestone Mar 16, 2021
@JKMarkowski JKMarkowski merged commit a08960d into main Mar 16, 2021
@JKMarkowski JKMarkowski deleted the fix/remove-table-leftovers branch March 16, 2021 09:00
@netlify
Copy link

netlify bot commented Mar 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants