Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: larger dropdown body #2218

Merged
merged 1 commit into from Mar 30, 2021
Merged

feat: larger dropdown body #2218

merged 1 commit into from Mar 30, 2021

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Mar 25, 2021

Related Issue

part of #2207

Description

There is applied hcange for max width of default dropdown body.
Due to fiori3 37,5rem -> 40rem.

Also there is added larger dropdown - achieved by class fd-list--large-dropdown

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

Before:

After:

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • Text elements follow the truncation rules
  • [NA] hover state of the element follow design spec
  • [Na] focus state of the element follow design spec
  • [NA] active state of the element follow design spec
  • [NA] selected state of the element follow design spec
  • [NA] selected hover state of the element follow design spec
  • [NA] pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@JKMarkowski JKMarkowski requested a review from a team March 25, 2021 11:48
@JKMarkowski JKMarkowski self-assigned this Mar 25, 2021
@JKMarkowski JKMarkowski added this to the Sprint 58 - Stockholm milestone Mar 25, 2021
@JKMarkowski JKMarkowski mentioned this pull request Mar 25, 2021
3 tasks
@netlify
Copy link

netlify bot commented Mar 25, 2021

Deploy preview for fundamental-styles ready!

Built with commit 5cd9cc6

https://deploy-preview-2218--fundamental-styles.netlify.app

@JKMarkowski JKMarkowski merged commit ecf1f7c into main Mar 30, 2021
@JKMarkowski JKMarkowski deleted the feat/select-update branch March 30, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants