Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove outline from radio button #2221

Merged
merged 1 commit into from Mar 30, 2021

Conversation

JKMarkowski
Copy link
Contributor

Related Issue

part of #2194

Description

Outline is removed from radio button label

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • focus state of the element follow design spec
  1. The code follows fundamental-styles code standards and style
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  1. Testing
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])

@JKMarkowski JKMarkowski requested a review from a team March 29, 2021 11:11
@JKMarkowski JKMarkowski self-assigned this Mar 29, 2021
@netlify
Copy link

netlify bot commented Mar 29, 2021

Deploy preview for fundamental-styles ready!

Built with commit 45aac09

https://deploy-preview-2221--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova merged commit 1c4c476 into main Mar 30, 2021
@InnaAtanasova InnaAtanasova deleted the fix/grid-list-radio-outline branch March 30, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants