Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list docs, focus colors on menu and object list [ci visual] #2222

Merged
merged 3 commits into from Mar 30, 2021

Conversation

JKMarkowski
Copy link
Contributor

Related Issue

part of #2194

Description

There is

  • fixed documentation for list
  • Added contrast outline color for menu items, when active
  • Added background color for object list, on active

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  1. Testing
  • Verified all styles in IE11
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • [NA] Storybook documentation has been created/updated
  • [NA] Breaking Changes wiki has been updated in case of breaking changes.

@JKMarkowski JKMarkowski requested a review from a team March 29, 2021 11:42
@JKMarkowski JKMarkowski self-assigned this Mar 29, 2021
@netlify
Copy link

netlify bot commented Mar 29, 2021

Deploy preview for fundamental-styles ready!

Built with commit 71a2cb8

https://deploy-preview-2222--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova merged commit b704440 into main Mar 30, 2021
@InnaAtanasova InnaAtanasova deleted the fix/defect-hunting-issues branch March 30, 2021 19:30
@N1XUS N1XUS mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants