Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce 2 new types of icons #2229

Merged
merged 17 commits into from Apr 6, 2021
Merged

feat: introduce 2 new types of icons #2229

merged 17 commits into from Apr 6, 2021

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes #2178

Description

Added 2 new font-families for icons: 'BusinessSuiteInAppSymbols' and 'SAP-icons-TNT'

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • [na] Text elements follow the truncation rules
  • [na] hover state of the element follow design spec
  • [na] focus state of the element follow design spec
  • [na] active state of the element follow design spec
  • [na] selected state of the element follow design spec
  • [na] selected hover state of the element follow design spec
  • [na] pressed state of the element follow design spec
  • [na] Responsiveness rules - the component has modifier classes for all breakpoints
  • [na] Includes Compact/Cosy/Tablet design
  • [na] RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • [na] A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated
  • [na] Breaking Changes wiki has been updated in case of breaking changes.

@InnaAtanasova InnaAtanasova added the denoland Issue will be handled/done by the Denoland team label Apr 1, 2021
@InnaAtanasova InnaAtanasova added this to the Sprint 59 - Helsinki milestone Apr 1, 2021
@InnaAtanasova InnaAtanasova requested a review from a team April 1, 2021 15:16
@InnaAtanasova InnaAtanasova self-assigned this Apr 1, 2021
@InnaAtanasova InnaAtanasova changed the title Feat/new icons feat: introduce 2 new types of icons Apr 1, 2021
@netlify
Copy link

netlify bot commented Apr 1, 2021

Deploy preview for fundamental-styles ready!

Built with commit 6e90890

https://deploy-preview-2229--fundamental-styles.netlify.app

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InnaAtanasova looks good but tests are failing

@InnaAtanasova InnaAtanasova merged commit 381958c into main Apr 6, 2021
@InnaAtanasova InnaAtanasova deleted the feat/new-icons branch April 6, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
denoland Issue will be handled/done by the Denoland team
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

introduce other SAP icons
3 participants