Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table fixed cells hover state #2233

Merged
merged 1 commit into from Apr 8, 2021
Merged

Conversation

platon-rov
Copy link
Contributor

@platon-rov platon-rov commented Apr 6, 2021

Related Issue

Relates to Fundamental-NGX #4163 - fix needed at the level of styles library.

Description

  • Fixed cell now inherits its parent row background-color
  • Fixed cell now have the right color on hover when it's inside of selected rov

Note: Borders is known issue, see #1948.

Screenshots

Before:

image

Hover:

image

After:

image

Hover:

image

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@platon-rov platon-rov changed the title fix: table fixed cells hover state [WIP] fix: table fixed cells hover state Apr 6, 2021
@netlify
Copy link

netlify bot commented Apr 6, 2021

Deploy preview for fundamental-styles ready!

Built with commit 7322905

https://deploy-preview-2233--fundamental-styles.netlify.app

@platon-rov platon-rov changed the title [WIP] fix: table fixed cells hover state fix: table fixed cells hover state Apr 6, 2021
@platon-rov platon-rov requested review from a team April 6, 2021 09:29
@SAP SAP deleted a comment from netlify bot Apr 7, 2021
@platon-rov platon-rov self-assigned this Apr 7, 2021
@platon-rov platon-rov added the Bug Something isn't working label Apr 7, 2021
@puru-hk
Copy link

puru-hk commented Apr 8, 2021

Looks fine

* Fixed cell now inherits it's parent row background color
* Fixed cell now have right color on hover when it's inside of selected rov
@platon-rov platon-rov merged commit d05754d into main Apr 8, 2021
@platon-rov platon-rov deleted the fix-table-fixed-hover-state branch April 8, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants