fix(styles): refactor checkbox to use a square not an icon for tristate #2905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
none
Description
Checkbox was using icon for the square that represents the tri-state. This was causing a lot of alignment issues and the new set of icons changed the look of this icon so we can no longer rely on it for the tri-state.
BREAKING CHANGE:
.fd-checkbox__label-container
that is necessary for the fake focus and the new way of implementing the tri-state.Before:
Now:
.fd-checkbox__label--required
for when the Checkbox is a required element. It replaces the.fd-from-label--required
modifier class.Before:
Now:
Please check whether the PR fulfills the following requirements
rem
fd-*
class is used in the filefd-rtl
,fd-ellipsis
,fd-flex
,fd-selected
,fd-focus
, ect.)fd-reset()
mixin is applied to all elementsnormalize
optionunnormalize
option[ci visual]
so it can trigger chromatic visual regression (e.g.test: run chromatic visual regression [ci visual]
)