New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix selection in menu styles #2907
Conversation
f8e4064
to
a2a1f70
Compare
✔️ Deploy Preview for fundamental-styles ready! 🔨 Explore the source changes: f8e4064 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/618bfab7206ad9000761cc0b 😎 Browse the preview: https://deploy-preview-2907--fundamental-styles.netlify.app |
✔️ Deploy Preview for fundamental-styles ready! 🔨 Explore the source changes: 5b33a9d 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/6197ff22f332b5000e949a38 😎 Browse the preview: https://deploy-preview-2907--fundamental-styles.netlify.app |
Could you please add before/after screenshots? |
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
@Betrozov you need to re-trigger the visual changes, Chromatic is now fixed |
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
Description
Corrected selection for menu component
It needs for fundamental-ngx in the case when we use fdp-menu-item component instead of li tag
Screenshots
Before:
After:
Please check whether the PR fulfills the following requirements
rem
fd-*
class is used in the filefd-rtl
,fd-ellipsis
,fd-flex
,fd-selected
,fd-focus
, ect.)fd-reset()
mixin is applied to all elementsnormalize
optionunnormalize
option[ci visual]
so it can trigger chromatic visual regression (e.g.test: run chromatic visual regression [ci visual]
)