Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix selection in menu styles #2907

Merged
merged 2 commits into from Nov 24, 2021
Merged

fix: fix selection in menu styles #2907

merged 2 commits into from Nov 24, 2021

Conversation

Betrozov
Copy link
Contributor

@Betrozov Betrozov commented Nov 10, 2021

Description

Corrected selection for menu component
It needs for fundamental-ngx in the case when we use fdp-menu-item component instead of li tag

Screenshots

Before:

Screenshot 2021-11-12 at 18 02 24

After:

Screenshot 2021-11-12 at 18 04 41

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • [n/a] All values are in rem
  • [n/a] Text elements follow the truncation rules
  • [n/a] hover state of the element follow design spec
  • [n/a] focus state of the element follow design spec
  • [n/a] active state of the element follow design spec
  • [n/a] selected state of the element follow design spec
  • [n/a] selected hover state of the element follow design spec
  • [n/a] pressed state of the element follow design spec
  • [n/a] Responsiveness rules - the component has modifier classes for all breakpoints
  • [n/a] Includes Compact/Cosy/Tablet design
  • [n/a] RTL support
  1. The code follows fundamental-styles code standards and style
  • [n/a] only one top level fd-* class is used in the file
  • [n/a] BEM naming convention is used
  • [n/a] Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • [n/a] A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • [n/a] fd-reset() mixin is applied to all elements
  • [n/a] Variables are used, if some value is used more than twice.
  • [n/a] Checked if current components can be reused, instead of having new code.
  1. Testing
  • [n/a] tested Storybook examples with "CSS Resources" normalize option
  • [n/a] tested Storybook examples with "CSS Resources" unnormalize option
  • [n/a] Verified all styles in IE11
  • [n/a] Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • [n/a] Storybook documentation has been created/updated
  • [n/a] Breaking Changes wiki has been updated in case of breaking changes.

@Betrozov Betrozov added the Enhancement New feature or request label Nov 10, 2021
@Betrozov Betrozov added this to the Sprint 75 - Ariba milestone Nov 10, 2021
@Betrozov Betrozov self-assigned this Nov 10, 2021
@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: f8e4064

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/618bfab7206ad9000761cc0b

😎 Browse the preview: https://deploy-preview-2907--fundamental-styles.netlify.app

@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: 5b33a9d

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/6197ff22f332b5000e949a38

😎 Browse the preview: https://deploy-preview-2907--fundamental-styles.netlify.app

@platon-rov
Copy link
Contributor

Could you please add before/after screenshots?

@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Nov 15, 2021
@InnaAtanasova
Copy link
Contributor

@Betrozov you need to re-trigger the visual changes, Chromatic is now fixed

@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Nov 18, 2021
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@Betrozov Betrozov merged commit 9fbde81 into main Nov 24, 2021
@Betrozov Betrozov deleted the fix-menu-item branch November 24, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants