Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fn): inconsistent text field borders across zoom levels [ci visual] #2911

Merged
merged 1 commit into from Nov 17, 2021

Conversation

darksmo
Copy link
Contributor

@darksmo darksmo commented Nov 16, 2021

Description

On some operating systems supporting sub-pixel rendering the browser may
inconsistently approximate the height/widths of boxes across zoom level. The
issue becomes apparent when multiple controls are placed together (e.g.,
table rows, tags, input boxes) as the user zooms in/out.

Specifying the border-width property is a solution that does not involve
using future CSS specs or GPU-based calculations.

Screenshots

Zoom level 80% - but the same issue occurs across multiple zoom levels.

Before:

image

After:

image

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • [na] All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • [na] tested Storybook examples with "CSS Resources" normalize option
  • [na] tested Storybook examples with "CSS Resources" unnormalize option
  • [na] Verified all styles in IE11
  • [na] Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • [na] Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

On some operating systems supporting sub-pixel rendering the browser may
inconsistently approximate the height/widths of boxes across zoom level. The
issue becomes apparent when multiple controls are placed together (e.g.,
table rows, tags, input boxes) as the user zooms in/out.

Specifying the border-width property is a solution that does not involve
using future CSS specs or GPU-based calculations.
@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: a4cc57d

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/6193ca3a5a955200077d505e

😎 Browse the preview: https://deploy-preview-2911--fundamental-styles.netlify.app

@darksmo
Copy link
Contributor Author

darksmo commented Nov 17, 2021

So, who is going to approve the UI review?

@droshev droshev self-assigned this Nov 17, 2021
@droshev droshev merged commit 08575b9 into main Nov 17, 2021
@droshev droshev deleted the fix-zoomborder-textfield branch November 17, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants