fix(fn): update Button component to latest Fiori Next design #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for fundamental-styles ready! 🔨 Explore the source changes: 9fed51a 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/61a04b9f2367aa00090e171f 😎 Browse the preview: https://deploy-preview-2932--fundamental-styles.netlify.app |
InnaAtanasova
force-pushed
the
fix/update-button
branch
from
8553a2c
to
1ddf316
Compare
droshev
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the design and types of the buttons per latest design.
Added segmented button.
BREAKING CHANGE:
updated modifier classes to follow the naming in the design
Before:
secondary | fn-button--secondary
flat | fn-button--flat
outline | fn-button--outline
naked | fn-button--naked
link | fn-button--link
After:
emphasized (primary) | fn-button--emphasized
ghost (secondary) | fn-button--ghost
neutral (secondary) | fn-button--neutral
transparent (layout) | fn-button--transparent
accept (semantic) | fn-button--accept
success (semantic) | fn-button--success
attention (semantic) | fn-button--attention
critical (semantic) | fn-button--critical
reject (semantic) | fn-button--reject
negative (semantic) | fn-button--negative
toggled (semantic) | fn-button--toggled