Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link, fix img align [ci visual] #3053

Merged
merged 1 commit into from Jan 7, 2022
Merged

fix: link, fix img align [ci visual] #3053

merged 1 commit into from Jan 7, 2022

Conversation

Betrozov
Copy link
Contributor

@Betrozov Betrozov commented Jan 5, 2022

Related Issue

part of defect hunting spring 77 SAP/fundamental-ngx#7362
issue has been raised in comment SAP/fundamental-ngx#7362 (comment)
6th issue

Description

fixed the over height of the img

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • [n/a] All values are in rem
  • [n/a] Text elements follow the truncation rules
  • [n/a] hover state of the element follow design spec
  • [n/a] focus state of the element follow design spec
  • [n/a] active state of the element follow design spec
  • [n/a] selected state of the element follow design spec
  • [n/a] selected hover state of the element follow design spec
  • [n/a] pressed state of the element follow design spec
  • [n/a] Responsiveness rules - the component has modifier classes for all breakpoints
  • [n/a] Includes Compact/Cosy/Tablet design
  • [n/a] RTL support
  1. The code follows fundamental-styles code standards and style
  • [n/a] only one top level fd-* class is used in the file
  • [n/a] BEM naming convention is used
  • [n/a] Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • [n/a] A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • [n/a] fd-reset() mixin is applied to all elements
  • [n/a] Variables are used, if some value is used more than twice.
  • [n/a] Checked if current components can be reused, instead of having new code.
  1. Testing
  • [n/a] tested Storybook examples with "CSS Resources" normalize option
  • [n/a] tested Storybook examples with "CSS Resources" unnormalize option
  • [n/a] Verified all styles in IE11
  • [n/a] Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • [n/a] Storybook documentation has been created/updated
  • [n/a] Breaking Changes wiki has been updated in case of breaking changes.

@Betrozov Betrozov added the Bug Something isn't working label Jan 5, 2022
@Betrozov Betrozov added this to the Sprint 78 - Ariba milestone Jan 5, 2022
@Betrozov Betrozov self-assigned this Jan 5, 2022
@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: 94b3430

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/61d572ea3787c00008860b8f

😎 Browse the preview: https://deploy-preview-3053--fundamental-styles.netlify.app

@droshev droshev merged commit d727c5f into main Jan 7, 2022
@droshev droshev deleted the fix-link branch January 7, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants