Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "pointer-events: none" from disabled form controls #3190

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

dmitry-stepanenko
Copy link
Contributor

Related Issue

Closes SAP/fundamental-ngx#7246

Description

In the textarea, we could have several lines. If the component is disabled, then it is not more possible to scroll through the lines.

Screenshot 2021-11-25 at 16 53 27

This PR removes "pointer-events: none" from form controls at all. Preserving it on "select" component, as the button handle should not be clickable

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

Before:

After:

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • [n/a] Verified all styles in IE11
  • [n/a] Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • [n/a] Storybook documentation has been created/updated
  • [n/a] Breaking Changes wiki has been updated in case of breaking changes.

@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: 477fd4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/620a68e84eb6890007765c31

😎 Browse the preview: https://deploy-preview-3190--fundamental-styles.netlify.app

@dmitry-stepanenko dmitry-stepanenko self-assigned this Feb 14, 2022
@dmitry-stepanenko dmitry-stepanenko added this to the Sprint 78 - Ariba milestone Feb 14, 2022
@droshev droshev merged commit 9a6f457 into main Feb 15, 2022
@droshev droshev deleted the ds/7246-disabled-textarea-fix branch February 15, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Textarea] Not possible to scroll if textarea is disabled
3 participants