Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fn): update Notifications to latest design [ci visual] #3194

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Part of #3166

Description

  • update Notifications to latest design
  • breaking change: use icon instead of object status in the semantic container, use nested button instead of layout button for close

Before:

<div class="fn-notification__semantic-container">
    <div class="fn-object-status fn-object-status--positive">
      <span class="sap-icon sap-icon--status-positive"></span>
    </div>
    <span class="fn-notification__semantic-title">Positive</span>
</div>
<button class="fn-button fn-button--layout fn-button--icon-only" aria-label="More">
      <span class="sap-icon sap-icon--decline"></span>
</button>

After:

<div class="fn-notification__semantic-container">
    <span class="sap-icon sap-icon--status-positive"></span>
    <span class="fn-notification__semantic-title">Positive</span>
</div>
<button class="fn-nested-button" aria-label="nested button">
    <span class="sap-icon sap-icon--decline"></span>
</button>

Screenshots

Before:

Screen Shot 2022-02-15 at 5 46 21 PM

Screen Shot 2022-02-15 at 5 46 27 PM

After:

Screen Shot 2022-02-15 at 5 46 59 PM

Screen Shot 2022-02-15 at 5 46 33 PM

@InnaAtanasova InnaAtanasova added this to the Sprint 81 - Santiago milestone Feb 15, 2022
@InnaAtanasova InnaAtanasova requested a review from a team February 15, 2022 22:49
@InnaAtanasova InnaAtanasova self-assigned this Feb 15, 2022
@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: bb07b48

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/620c34c6ccc5bd0007eb4d18

😎 Browse the preview: https://deploy-preview-3194--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova force-pushed the fix/fn-notifications-update branch 2 times, most recently from 872c201 to 0747ce8 Compare February 15, 2022 23:01
@InnaAtanasova InnaAtanasova merged commit 4b8a741 into main Feb 16, 2022
@InnaAtanasova InnaAtanasova deleted the fix/fn-notifications-update branch February 16, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants