Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): stories order #3839

Merged
merged 1 commit into from
Sep 18, 2022
Merged

fix(docs): stories order #3839

merged 1 commit into from
Sep 18, 2022

Conversation

platon-rov
Copy link
Contributor

[BLOCKED] till storybook changes are not reviewed on main.

Related Issue

Closes #3287

Description

Stories order set to order in a file instead of alphabetical sorting.

Screenshots

Before:

зображення

After:

зображення

@platon-rov platon-rov added Enhancement New feature or request blocked labels Aug 31, 2022
@platon-rov platon-rov requested a review from a team August 31, 2022 16:25
@platon-rov platon-rov self-assigned this Aug 31, 2022
@netlify
Copy link

netlify bot commented Aug 31, 2022

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit ba45184
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/630f8b8609c32b000890b52f
😎 Deploy Preview https://deploy-preview-3839--fundamental-styles.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

InnaAtanasova
InnaAtanasova approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had in my to-do list to fix this, super annoying. Thanks for the fix!

g-cheishvili
g-cheishvili approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@g-cheishvili g-cheishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not get why you guys are frustrated over this but I approve 😊

@droshev droshev added this to the Sprint 97 - Santa Cruz milestone Sep 18, 2022
@droshev droshev merged commit 5b6d466 into main Sep 18, 2022
@droshev droshev deleted the pr/fix/stories-order branch September 18, 2022 02:02
@platon-rov platon-rov mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@g-cheishvili g-cheishvili g-cheishvili approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@platon-rov platon-rov

Labels
blocked Enhancement New feature or request
Projects
Development
  
Awaiting triage
Milestone
Sprint 97 - Santa Cruz
Development

Successfully merging this pull request may close these issues.

bug: examples displayed in wrong order
5 participants
@platon-rov @mikerodonnell89 @g-cheishvili @InnaAtanasova @droshev