docs: remove SCSS from the landing page, update library name #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droshev
force-pushed
the
docs/427-remove-scss-from-names
branch
from
0f2f91e
to
de6469e
Compare
|
Deploy preview for fundamental-styles ready! Built with commit 0f2f91e |
|
Deploy preview for fundamental-styles ready! Built with commit daf265b |
droshev
requested review from
jbadan,
greg-a-smith,
markpalfreeman,
bcullman,
InnaAtanasova,
stefanoScalzo and
trilodge
|
date picker & multiimput are 404/ navigating to wrong locations in patterns section: https://deploy-preview-429--fundamental-styles.netlify.com/patterns/multi-input.html |
jbadan
reviewed
Nov 18, 2019
| - title: Combobox Input | ||
| url: /patterns/combobox-input.html | ||
| - title: Date Picker | ||
| url: /patterns/multi-input.html |
There was a problem hiding this comment.
I think this is the cause of the 404
jbadan
reviewed
Nov 18, 2019
| <span class="fd-toggle fd-toggle--xs"> | ||
| <input class="toggle-bg fd-toggle__input" type="checkbox" name="" value="" id="{{ randomNumber }}"> | ||
| <span class="fd-toggle__switch" role="presentation"></span> | ||
| </span> |
There was a problem hiding this comment.
Why are we getting rid of the background toggle?
There was a problem hiding this comment.
What is the actual value of this?
droshev
force-pushed
the
docs/427-remove-scss-from-names
branch
from
de6469e
to
925b21a
Compare
InnaAtanasova
approved these changes
Nov 21, 2019
config/postcss.config.js
Outdated
| postcssAddFallback({importFrom: 'dist/root.css'}), | ||
| postcssAddFallback({importFrom: 'node_modules/@sap-theming/theming-base-content/content/Base/baseLib/sap_fiori_3/css_variables.css'}), | ||
| postcssAddFallback({ importFrom: 'dist/root.css' }), | ||
| postcssAddFallback({ importFrom: 'node_modules/@sap-theming/theming-base-content/content/Base/baseLib/sap_fiori_3/css_variables.css' }), |
There was a problem hiding this comment.
Could you revert the re-formatting?
droshev
force-pushed
the
docs/427-remove-scss-from-names
branch
2 times, most recently
from
5d39458
to
48d92c8
Compare
droshev
force-pushed
the
docs/427-remove-scss-from-names
branch
from
48d92c8
to
daf265b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #427