Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: section lines added according to Fiori 3 #488

Merged
merged 5 commits into from Jan 17, 2020
Merged

fix: section lines added according to Fiori 3 #488

merged 5 commits into from Jan 17, 2020

Conversation

rengare
Copy link
Contributor

@rengare rengare commented Dec 4, 2019

Related Issue

Closes #461

Description

  • Order of css classes has been changed
  • New border bottom rule added for product switch item in mobile view

Screenshots

Before:

69462880-32d75280-0d48-11ea-8a17-c90311e1077f

After:

after
after rtl
after rtl active

@claassistantio
Copy link

claassistantio commented Dec 4, 2019

CLA assistant check
All committers have signed the CLA.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gracjan Gorecki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Dec 4, 2019

Deploy preview for fundamental-styles ready!

Built with commit 0972438

https://deploy-preview-488--fundamental-styles.netlify.com

@rengare rengare changed the title fix:#461 fixed fix: section lines added according to Fiori 3 Dec 4, 2019
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2019-12-06 at 3 06 04 PM

Screen Shot 2019-12-06 at 3 06 34 PM

This is not exactly fixing the issue. When the item is selected you can clearly see the white "padding" on top, left and right. Not sure it's broken now or from another PR, but the ... has a white background when the item is selected

@InnaAtanasova InnaAtanasova added this to In progress in Development via automation Jan 6, 2020
@InnaAtanasova InnaAtanasova added this to the Sprint 28 - Sydney milestone Jan 6, 2020
@InnaAtanasova InnaAtanasova moved this from In progress to Review in progress in Development Jan 6, 2020
@stefanoScalzo
Copy link
Contributor

Screen Shot 2019-12-06 at 3 06 04 PM Screen Shot 2019-12-06 at 3 06 34 PM

This is not exactly fixing the issue. When the item is selected you can clearly see the white "padding" on top, left and right. Not sure it's broken now or from another PR, but the ... has a white background when the item is selected

I agree with Inna! try and add it to the paddings instead of the margins

@rengare
Copy link
Contributor Author

rengare commented Jan 14, 2020

@InnaAtanasova PR was updated, I have fixed few things and resolved conflicts with master

@InnaAtanasova
Copy link
Contributor

InnaAtanasova commented Jan 15, 2020

Everything is perfect (Great job fixing the issue with the little white line between the border and the background!!!!). There's a small issue on hover:
Screen Shot 2020-01-15 at 1 27 26 PM

P.S. For some reason it doesn't show for each element. Check Strategic Procurement, Human Capital Management, Service Cloud, etc.

@rengare
Copy link
Contributor Author

rengare commented Jan 17, 2020

Everything is perfect (Great job fixing the issue with the little white line between the border and the background!!!!). There's a small issue on hover:
Screen Shot 2020-01-15 at 1 27 26 PM

P.S. For some reason it doesn't show for each element. Check Strategic Procurement, Human Capital Management, Service Cloud, etc.

Fixed
product-switch-hover-fix

Development automation moved this from PRs Review in progress to PRs Reviewer approved Jan 17, 2020
@InnaAtanasova InnaAtanasova merged commit a04d6eb into SAP:master Jan 17, 2020
Development automation moved this from PRs Reviewer approved to Done Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Product Switch broken in Firefox
4 participants