fix: Align side-nav navigation arrow on IE11 #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Michal Salamon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Deploy preview for fundamental-styles ready! Built with commit ca81f98 |
salarenko
changed the title
JKMarkowski
force-pushed
the
fix/485-side-navigation-arrow-align-ie
branch
from
76ae625
to
04c23d9
Compare
InnaAtanasova
requested changes
Dec 23, 2019
Comment on lines
-10
to
-15
| <ul class="test-sidenav-list"> | ||
| <li>Item 1</li> | ||
| <li>Item 1</li> | ||
| <li>Item 1</li> | ||
| <li>Item 1</li> | ||
| </ul> |
There was a problem hiding this comment.
We shouldn't bring the nested list in sidenav. There are tests for Nested list. Inside Sidenav tests we should only test the Sidenav styling because our components are self-contained. You should revert the test changes
There was a problem hiding this comment.
Restored previous test cases
stefanoScalzo
approved these changes
Jan 9, 2020
InnaAtanasova
approved these changes
Jan 15, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning side-nav navigation arrow on IE11.
Related Issue
Closes #485
Description
Error occurred because of IE11 breaking
align-items: centerafter settingmin-heightof an element. One of the workarounds enabling usingmin-heightwithout breaking flex-box properties is to additionally setheight<min-height.More about the issue: philipwalton/flexbugs#231
Merge also includes updated side-nav playground template, providing updated html structure and 3 common side-navs usages.