fix: Broken product switch on mobile devices - IE11 #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salarenko
changed the title
|
Deploy preview for fundamental-styles ready! Built with commit 11a1b45 |
@salarenko , could you work on this after the holidays? Any improvements are more than welcome |
InnaAtanasova
requested review from
InnaAtanasova,
stefanoScalzo,
JKMarkowski and
droshev
InnaAtanasova
approved these changes
Dec 23, 2019
stefanoScalzo
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #531
Description
IE11 has problem with
flex-basisvalue. For some reason IE11 doesn't respect elementsheightvalue ifflex-basis: 25%is used.Since in mobile mode products are aligned as a list, my solution is changing to
flex-basis: autoon mobiles.To be honest product-switch styles are a little bit messy. I'd recommend small refactor in the future.
Before:
After: