fix: (InputGroup) Add min-width property only for ie10+, fix addon truncation #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
changed the title
|
Deploy preview for fundamental-styles ready! Built with commit 5be5a87 |
src/input-group.scss
Outdated
| @@ -72,7 +72,7 @@ $fd-input-border-radius: var(--sapField_BorderCornerRadius); | |||
|
|
|||
| background-color: transparent; | |||
| border: none; | |||
| flex: 1 1 auto; | |||
| flex: 1 1; | |||
JKMarkowski
force-pushed
the
fix/554-input-group
branch
from
4b9111d
to
5be5a87
Compare
InnaAtanasova
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #554
Description
We had some bug on input-group component, which was caused by setting
autoproperty forflex-basis. It was mostly because of IE11, which doesn't have any nativemin-widthforinputsScreenshots
Before:
IE11:
All browsers:
After:
IE11:
All browsers:
