Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: landing page #559

Merged
merged 6 commits into from
Jan 7, 2020
Merged

docs: landing page #559

merged 6 commits into from
Jan 7, 2020

Conversation

InnaAtanasova
Copy link
Contributor

This is the implementation of the landing page. There are a few minor things to be changed when Leo gets back from vacation (update 1-2 logos and the background images in the first section and "More About Fundamental Library Setion). Here are the screenshots from Zeplin (the visuals):

Desktop:
Screen Shot 2020-01-03 at 1 56 12 PM
Screen Shot 2020-01-03 at 1 57 39 PM
Screen Shot 2020-01-03 at 1 57 34 PM
Screen Shot 2020-01-03 at 1 57 21 PM

Mobile:
Screen Shot 2020-01-03 at 1 56 50 PM
Screen Shot 2020-01-03 at 1 56 43 PM
Screen Shot 2020-01-03 at 1 56 37 PM
Screen Shot 2020-01-03 at 1 56 28 PM

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for fundamental-styles ready!

Built with commit fec2948

https://deploy-preview-559--fundamental-styles.netlify.com

@estelaxu3
Copy link

estelaxu3 commented Jan 3, 2020

It looks awesome, thank you for bringing it to life!

Couple things I noticed:

  1. Key feature content should be left aligned instead of centered.
    Zeplin file:
    Screen Shot 2020-01-03 at 2 13 04 PM

  2. Could we add hover effect to the library tiles? All four tiles are currently outlined and have shadows, maybe we can take out the shadow when the tile is not selected so it is more interactive and responsive.

@Vanessa-Cusmich
Copy link
Contributor

Vanessa-Cusmich commented Jan 3, 2020 via email

@InnaAtanasova
Copy link
Contributor Author

It looks awesome, thank you for bringing it to life!

Couple things I noticed:

  1. Key feature content should be left aligned instead of centered.
    Zeplin file:
    Screen Shot 2020-01-03 at 2 13 04 PM
  2. Could we add hover effect to the library tiles? All four tiles are currently outlined and have shadows, maybe we can take out the shadow when the tile is not selected so it is more interactive and responsive.

Done

@InnaAtanasova
Copy link
Contributor Author

Agreed, it looks great! I was also thinking we should remove the links below the social media logos and hyperlink the images. Thanks! Vanessa >.

Done

@bcullman
Copy link
Contributor

bcullman commented Jan 4, 2020

pls. recheck layout on mobile - footer text is overlapping.

@droshev droshev added the Doc website documentation website label Jan 6, 2020
@droshev droshev added this to In progress in Development via automation Jan 6, 2020
@droshev droshev added this to the Sprint 26 - Sprint 27 Rome milestone Jan 6, 2020
@InnaAtanasova
Copy link
Contributor Author

pls. recheck layout on mobile - footer text is overlapping.

It's fixed now. Was a Safari issue. Thanks for catching it

@InnaAtanasova InnaAtanasova moved this from In progress to Review in progress in Development Jan 6, 2020
}
}

@media (max-width: 768px){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @InnaAtanasova
What about adding only one media query per max-width?
From largest (1024px) to smallest (600px)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest is perfect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look good without this breakpoint. O.w. it's not a problem to change it from 768 to 600px

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the section looks like at 630px:
Screen Shot 2020-01-07 at 8 17 48 AM

This is how the section looks like compared to the other sections:
Screen Shot 2020-01-07 at 8 18 12 AM
Screen Shot 2020-01-07 at 8 18 32 AM

@estelaxu3
Copy link

LGTM

Development automation moved this from PRs Review in progress to PRs Reviewer approved Jan 7, 2020
@InnaAtanasova InnaAtanasova merged commit cf353f4 into master Jan 7, 2020
Development automation moved this from PRs Reviewer approved to Done Jan 7, 2020
@InnaAtanasova InnaAtanasova deleted the docs/landpage branch January 7, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc website documentation website
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants