fix: form messages margin fix for textarea #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-styles ready! Built with commit 58b465d |
docs/pages/components/form.md
Outdated
| @@ -156,27 +156,28 @@ The state of the input field can reflect validity of the data entered, whether t | |||
| Along with Invalid and Warning, error messages should be displayed below the field so the user can correct the error and move forward. | |||
|
|
|||
| {% capture inputs %} | |||
| <div class="fd-form-item fd-has-margin-none fd-popover"> | |||
| <div class="fd-form-item fd-popover"> | |||
There was a problem hiding this comment.
You actually don't need fd-popover. This example doesn't have a message
|
@stefanoScalzo is off Monday so I pushed some changes into his PR (removed classes that we don't need, add |
mikerodonnell89
approved these changes
Jan 17, 2020
JKMarkowski
approved these changes
Jan 20, 2020
InnaAtanasova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #590
Description
Putting margins to make form messages and shadow fiori 3 compliant. Shadow doesn't have the same visuals as UI5 BUT is right according to specs. Did not include input screenshots because since it is behind the border they won't be visible
Screenshots
Before:
After: