Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce Dialog as successor for Modal - Fiori 3 refactor #687

Merged
merged 26 commits into from
Feb 21, 2020
Merged

feat: Introduce Dialog as successor for Modal - Fiori 3 refactor #687

merged 26 commits into from
Feb 21, 2020

Conversation

salarenko
Copy link
Contributor

@salarenko salarenko commented Feb 21, 2020 •
edited

This is #513 from branch moved to origin

Related Issue

Closes #512

Description

Changes introduce:

  • new component Dialog replacing Modal
  • Dialog component matching Fiori3 standard
  • update of Fundamental Styles documentation
  • update of developers playground examples
  • removed fd-overlay support for Modal

Dialog component is composed out of:

  • Bar representing dialogs:
    • header
    • subheader
    • footer
  • Busy Indicator
    • loader

Screenshots

image

image

image

image

salarenko and others added 23 commits February 21, 2020 11:16
@salarenko
Refactor and suit to Fiori3 standards | Problem with fading colors | …
c4de349 
…No resize handle done
@salarenko
Enable css resizing
cb2b52a
@salarenko
Fix missing resize icon | Add modal content size classes | Add modal …
781ed7e 
…compact class
@salarenko
Update modal playground
c6dffd1
@salarenko
Move overlay to modal shell
dec8391
@salarenko
Update Fundamental Library Styles documentation
bed2b0d
@salarenko
Use substitute color values for overlay and header shadow
c0a63f0
@salarenko
Cleanup | Update documentation
03651e4
@JKMarkowski @salarenko
Add reference images for testing
5ce03ad
@salarenko
feat(core) update modal sizing on mobile devices | Add --emphasized b…
55a585b 
…uttons | add scss values replacements
@salarenko
Fix modal sizing to Fiori3 documentation
1b8b9bf
@salarenko
feat(core) Update modal styling | Compose modal with Bar component | …
9387452 
…Compose modal with Busy Indicator component
@salarenko
feat(core) Update tests | Update documentation examples
e11fd60
@salarenko
feat(core) rename to dialog | remove unused docs
f00ecef
@salarenko
feat(core) add footer button
acf65d6
@salarenko
feat(core) Remove CSS media-queries
d069887
@salarenko
feat(core) docs update
6612b8f
@salarenko
feat(core) Remove unsupported JS methods - IE11
2356c0b
@salarenko
Add IE11 cursor fallback | Style example buttons
69b2627
@salarenko
Add resize handle as separate element
078e7c2
@salarenko
Split Dialog test images
a3008b5
@JKMarkowski @salarenko
Update Reference Images
d45cd4c
@JKMarkowski
Update test images
0b5ace9
@netlify
Copy link

netlify bot commented Feb 21, 2020 •
edited

Deploy preview for fundamental-styles ready!

Built with commit 98bf3a1

https://deploy-preview-687--fundamental-styles.netlify.com

@salarenko salarenko merged commit 704de9b into master Feb 21, 2020
@salarenko salarenko mentioned this pull request Feb 21, 2020
Closed
@droshev droshev deleted the feat/dialog-fiori3_2 branch February 21, 2020 21:00
@jbadan jbadan mentioned this pull request Feb 28, 2020
Open
@salarenko salarenko linked an issue Mar 2, 2020 that may be closed by this pull request
fd-overlay--modal uses .is-hidden instead of aria-hidden="true" #399
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rengare rengare rengare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@salarenko @rengare @JKMarkowski