Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minimal input width on IE11 #691

Merged
merged 2 commits into from Mar 9, 2020
Merged

fix: Minimal input width on IE11 #691

merged 2 commits into from Mar 9, 2020

Conversation

salarenko
Copy link
Contributor

Related Issue

Closes #690

Description

On IE11 when container uses display: flex min-width property is ignored. Basic width can be set using flex-basis property.

Before:
image

After:
image

@salarenko salarenko added this to the Sprint 31 - Sofia milestone Feb 21, 2020
@netlify
Copy link

netlify bot commented Feb 21, 2020 •
edited

Deploy preview for fundamental-styles ready!

Built with commit 8f9da57

https://deploy-preview-691--fundamental-styles.netlify.com

@InnaAtanasova InnaAtanasova added this to PRs Review in progress in Development via automation Feb 21, 2020
InnaAtanasova
InnaAtanasova previously requested changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments in Slack regarding the solution Brad from Concur provided.

@salarenko
Copy link
Contributor Author

Please check my comments in Slack regarding the solution Brad from Concur provided.

Then I think we can set flex-basis for each browser. This won't change current behavior of input elements and will fix IE11 issue.

@droshev
Copy link
Contributor

droshev commented Feb 24, 2020 •
edited

Let's just remove the IE specific fix and leave the width issue to the app developer.
In the documentation we can set width to 100% so the date picker will be consistent

@kavya-b kavya-b mentioned this pull request Feb 27, 2020
Merged
@droshev droshev added 0.8.0 and removed 0.7.0 labels Feb 28, 2020
@salarenko
Copy link
Contributor Author

Let's just remove the IE specific fix and leave the width issue to the app developer.
In the documentation we can set width to 100% so the date picker will be consistent

I don't think this is a valid solution. TBD during daily.

@droshev droshev self-requested a review March 6, 2020 14:34
@salarenko salarenko dismissed InnaAtanasova’s stale review March 9, 2020 12:33

This has been discussed and resolved

Development automation moved this from PRs Review in progress to PRs Reviewer approved Mar 9, 2020
@salarenko salarenko merged commit d4315e9 into master Mar 9, 2020
Development automation moved this from PRs Reviewer approved to Done Mar 9, 2020
@droshev droshev deleted the fix/690-localization-IE11 branch March 10, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@rengare rengare rengare approved these changes

@mikerodonnell89 mikerodonnell89 Awaiting requested review from mikerodonnell89

@JKMarkowski JKMarkowski Awaiting requested review from JKMarkowski

@stefanoScalzo stefanoScalzo Awaiting requested review from stefanoScalzo

@InnaAtanasova InnaAtanasova Awaiting requested review from InnaAtanasova

Assignees
No one assigned
Labels
None yet
Projects
Development
  
Done
Milestone
Sprint 32 - Miami
Development

Successfully merging this pull request may close these issues.

Broken input layout in localization (IE11)
4 participants
@salarenko @droshev @rengare @InnaAtanasova