Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Menu refactor to Fiori3 #702

Merged
merged 12 commits into from
Mar 29, 2020
Merged

feat: Menu refactor to Fiori3 #702

merged 12 commits into from
Mar 29, 2020

Commits on Mar 27, 2020

  1. feat: fiori3 menu refactor

    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    46ad1ee View commit details
    Browse the repository at this point in the history

  2. addressed review comments: changed to classes for compact-desktop, mo… 

    …bile mode

- keeping tablet cozy as the default
- added rtl example
- fixed IE submenu width issue
- changed option-name to title
- removed float usage
- provided examples for cozy, compact and mobile mode
- updated screenshots, tests, documentation
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    86aa623 View commit details
    Browse the repository at this point in the history

  3. fix for underliine on <a> tag 

    replaced <a> tag with <span> tag
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5994ca6 View commit details
    Browse the repository at this point in the history

  4. redundant code removed plus some side effects fixed 

    -removing redundant span container tag and moving fd-menu__item to li tag instead- for submenu though it has to have its parent menu item in its own span so that parent's states do not override submenu states
-added role and tabindex to show tab order and focus
added fd-fiori-focus() new function instead of defining in menu.scss- uses inner focus instead of outer focus
-updated playground
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f219be9 View commit details
    Browse the repository at this point in the history

  5. disabled pointer events fix, updated visual tests for rtl

    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f169337 View commit details
    Browse the repository at this point in the history

  6. addressing review comments 

    - removed redundant right-arrow icons when submenu was not reeally present
- instead used other icons to showcase secondary icon size
- using separator in a different element
- removed 'desktop' from modifier class name
- removed transition property
- applied font-size on icon directly
- updated playground tests and screenshots accordingly - added selected-separated usecase to visual test
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0581b16 View commit details
    Browse the repository at this point in the history

  7. modify name of separator class in accordance with BEM methodology 

    Renamed to fd-menu__separator
modified playground test and documentation
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    325cc79 View commit details
    Browse the repository at this point in the history

  8. addressing review comments 

    removed comment from code
added description  and usage of classes to documentation
removed hybrid usage of icons and long text from documentation, keeping it consistent, all these combinations are already preseent in playground
added breaking changes to pr description
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    59f07ce View commit details
    Browse the repository at this point in the history

  9. fixed separator playground issue, added <a> tag and link classes 

    -added link class to aid implementation and support accessibility per aria standards.
-added some aria attributes
-modified playground test and documentation to support above changes
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    2b6b270 View commit details
    Browse the repository at this point in the history

  10. fix: make menu separator self-contained; update tests and doc

    @droshev @kavya-b
    droshev authored and kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f5dc5cb View commit details
    Browse the repository at this point in the history

  11. updated mobile mode documentation for submenu 

    -also added is-selected mode and right/left arrow automatically on has-child class
-using --submenu modifier on addon-after element will add the right arrow by default, if custom icon needs to be added, one can use it same as addon-before element without --submenu modifier.
-updated playground tests and documentation to reflect these changes
    @kavya-b
    kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    ec3e2df View commit details
    Browse the repository at this point in the history

  12. docs: limit the height of the dialogs rendered inline on the doc site

    @droshev @kavya-b
    droshev authored and kavya-b committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    ee0c701 View commit details
    Browse the repository at this point in the history