New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: radio and checkbox button RTL alignments #753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for fundamental-styles ready! Built with commit 8a285b3 |
droshev
force-pushed
the
fix/checkbox-alignment-RTL
branch
2 times, most recently
from
March 3, 2020 20:53
0f1152e
to
b60fde0
Compare
droshev
force-pushed
the
fix/checkbox-alignment-RTL
branch
2 times, most recently
from
March 3, 2020 21:34
66723a8
to
5df54bf
Compare
InnaAtanasova
requested changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The focus is still broken in RTL
droshev
force-pushed
the
fix/checkbox-alignment-RTL
branch
from
March 4, 2020 12:51
5df54bf
to
8a285b3
Compare
this is because i didn't commit one more file I changed :) |
estelaxu3
approved these changes
Mar 4, 2020
InnaAtanasova
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
fixes: #733
Before:
After: