Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: radio and checkbox button RTL alignments #753

Merged
merged 2 commits into from Mar 4, 2020

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Mar 3, 2020

Related Issue

fixes: #733

Before:

Screen Shot 2020-03-03 at 4 07 47 PM

Screen Shot 2020-03-03 at 4 07 44 PM

Screen Shot 2020-03-03 at 4 07 35 PM

Screen Shot 2020-03-03 at 4 07 31 PM

After:

Screen Shot 2020-03-04 at 7 51 49 AM
Screen Shot 2020-03-04 at 7 51 43 AM
Screen Shot 2020-03-04 at 7 51 35 AM
Screen Shot 2020-03-04 at 7 51 16 AM

@netlify
Copy link

netlify bot commented Mar 3, 2020

Deploy preview for fundamental-styles ready!

Built with commit 8a285b3

https://deploy-preview-753--fundamental-styles.netlify.com

@droshev droshev force-pushed the fix/checkbox-alignment-RTL branch 2 times, most recently from 0f1152e to b60fde0 Compare March 3, 2020 20:53
@droshev droshev requested review from a team and jbadan March 3, 2020 20:57
@droshev droshev self-assigned this Mar 3, 2020
@droshev droshev added Bug Something isn't working RTL labels Mar 3, 2020
@droshev droshev added this to the Sprint 32 - Miami milestone Mar 3, 2020
@droshev droshev force-pushed the fix/checkbox-alignment-RTL branch 2 times, most recently from 66723a8 to 5df54bf Compare March 3, 2020 21:34
@estelaxu3
Copy link

I think there is another half dotted line missing in the RTL layout.
Screen Shot 2020-03-03 at 4 40 52 PM
Screen Shot 2020-03-03 at 4 40 39 PM

Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus is still broken in RTL

@InnaAtanasova InnaAtanasova added this to PRs Review in progress in Development via automation Mar 4, 2020
@droshev droshev force-pushed the fix/checkbox-alignment-RTL branch from 5df54bf to 8a285b3 Compare March 4, 2020 12:51
@droshev
Copy link
Contributor Author

droshev commented Mar 4, 2020

The focus is still broken in RTL

this is because i didn't commit one more file I changed :)

@droshev droshev requested review from InnaAtanasova and a team March 4, 2020 12:52
Development automation moved this from PRs Review in progress to PRs Reviewer approved Mar 4, 2020
@droshev droshev merged commit 70d852f into master Mar 4, 2020
Development automation moved this from PRs Reviewer approved to Done Mar 4, 2020
@droshev droshev deleted the fix/checkbox-alignment-RTL branch March 4, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working RTL
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Broken RTL for Checkbox and Radio Buttons
3 participants