Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: tree to make popover not go off of page #766

Merged
merged 1 commit into from Mar 5, 2020
Merged

docs: tree to make popover not go off of page #766

merged 1 commit into from Mar 5, 2020

Conversation

stefanoScalzo
Copy link
Contributor

Related Issue

Closes #739

Description

Since fundamental-styles doesn't use popover JS, we need to use the popover--right modifiers so that it doesn't go off the page

Screenshots

Before:

Screen Shot 2020-03-05 at 9 58 58 AM

After:

Screen Shot 2020-03-05 at 9 57 51 AM

@stefanoScalzo stefanoScalzo requested a review from a team March 5, 2020 14:59
@netlify
Copy link

netlify bot commented Mar 5, 2020

Deploy preview for fundamental-styles ready!

Built with commit 6cd70ea

https://deploy-preview-766--fundamental-styles.netlify.com

jbadan
jbadan approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@stefanoScalzo stefanoScalzo merged commit 1525e7e into master Mar 5, 2020
@stefanoScalzo stefanoScalzo deleted the fix/tree branch March 5, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iPad Visual Testing: Popover render in Tree is cut off
2 participants
@stefanoScalzo @jbadan