fix: add input-message-group popover specific rules to popper elements #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnaAtanasova
requested review from
droshev,
bcullman,
rengare,
greg-a-smith,
salarenko,
JKMarkowski,
jbadan and
stefanoScalzo
|
Deploy preview for fundamental-styles ready! Built with commit c636229 |
droshev
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For a11y reasons the input field has margin-top and margin-bottom. When the input field is used as a popover control this causes the popover body to look "detached" from the control element. One example is the form-messages that are used for input validation. For this reason we added a modifier class to the popover
--input-message-groupthat is removing the shadow (border) from the popover body and is bringing it 0.25rem top. In NGX we are using Popper.js and we need to apply the same rules as we did for the popover body in Fundamental-styles. We added the--input-message-groupmodifier class to the__popperbut due to the fundamental-ngx Popover specific implementation we don't have the option to apply this class to the body. We are keeping the modifier class as it was since other libs can use it but we are also adding additional rules.