docs: step input component into patterns #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadan
commented
Mar 6, 2020
| - title: Step Input | ||
| url: /patterns/step-input.html | ||
| output: web | ||
|
|
There was a problem hiding this comment.
How do we make the pictures for the index page?
There was a problem hiding this comment.
@estelaxu3 do you think you can help in this?
There was a problem hiding this comment.
I make them in Adobe XD :D :D :D But I am terrible at this
|
Deploy preview for fundamental-styles ready! Built with commit 71480d9 |
InnaAtanasova
approved these changes
Mar 6, 2020
droshev
approved these changes
Mar 6, 2020
|
these would be more useable if the buttons were both on the same side. is this possible? |
|
@bcullman that wouldn't match the design spec though |
|
have the designers actually tried using the stuff they design? :) we should bring it up with them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes SAP/fundamental-styles#
Description
Fundamental react had a contributor create a "StepInput" component that matches design specs using existing Fundamental Styles styles - SAP/fundamental-react#914
Adding this patterns page to the documentation website so the libraries stay in sync.