fix: make compact tokenizer inner width: auto and make cozy mode horizontally scrollable #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-styles ready! Built with commit 447466c |
mikerodonnell89
force-pushed
the
fix/tokenizer-inner-refactor
branch
from
146e410
to
59edd97
Compare
mikerodonnell89
changed the title
|
Hello @mikerodonnell89 is it done by purpose? Ie11: |
mikerodonnell89
changed the title
InnaAtanasova
previously requested changes
Mar 13, 2020
InnaAtanasova
requested review from
JKMarkowski,
salarenko,
rengare and
droshev
2 tasks
mikerodonnell89
changed the title
mikerodonnell89
commented
Mar 16, 2020
| @@ -280,3 +285,75 @@ To show focus on whole element, it's needed to add `.is-focus` into container. | |||
| </div> | |||
| {% endcapture %} | |||
| {% include display-component.html component=compact-tokenizer %} | |||
|
|
|||
| ## Tokenizer - Scrollable | |||
| The Compact tokenizer is for large screens. | |||
There was a problem hiding this comment.
This is the cozy tokenizer. And the user won't have tab keys in cozy mode (phone/tablet)
There was a problem hiding this comment.
In my my approach, there is added --scrollable, which can be added in cozy and compact mode.
|
@mikerodonnell89 This one is on mobile/tablets/touch devices |
jbadan
reviewed
Mar 17, 2020
src/tokenizer.scss
Outdated
| @@ -38,7 +44,7 @@ $block: #{$fd-namespace}-tokenizer; | |||
| &__input { | |||
| border: none !important; | |||
| min-width: 3rem !important; | |||
| padding: 0 $fd-tokenizer-spacing 0 0 !important; | |||
| padding: 0 !important; | |||
There was a problem hiding this comment.
Did we want to keep with the important! pattern here or switch to the new pattern we did with shellbar buttons?
There was a problem hiding this comment.
Now it's handled like on shellbar, thanks for pointing it out :)
InnaAtanasova
approved these changes
Mar 18, 2020
droshev
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes SAP/fundamental-styles# #774