feat: add internal label to switch component #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-styles ready! Built with commit 66930d9 |
|
Could you please add more meaningful title for the PR? Thank you :) |
rengare
approved these changes
Mar 16, 2020
JKMarkowski
changed the title
JKMarkowski
changed the title
InnaAtanasova
requested review from
InnaAtanasova,
mikerodonnell89,
salarenko and
droshev
JKMarkowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #664
Description
There are some cleanups with switch component. We had
&__textleftover. Now this element should be used outside of the switch.Focus stays only for switch, even if text is there
&__iconelement is standalone, it doesn't need&__textanymore.There is also 1 test added with switch + text and 1 section example with switch + text.
I changed also
left/rightcss properties totransform: translate(x,y). Thanks to this component is better interpreted by browsers and is not very dependent on relative parent. Also this approach is much cleaner and easier to maintain.Tested on IE11
Screenshots
Before:
After: