fix: update the line-height of the Object Status #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnaAtanasova
requested review from
mikerodonnell89,
droshev,
salarenko,
JKMarkowski,
stefanoScalzo,
Lokanathan-k and
estelaxu3
|
Deploy preview for fundamental-styles ready! Built with commit cf666d2 |
droshev
approved these changes
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
display: inline-flexto center the text and the icon in the spandisplay: inline-blockbecause we need to remove the underline from the icon on hover and this is achievable only when the span hasdisplay: inline-blockScreenshots
The line height is affecting the heigh of the elements, hence the updated tests but it's hard to "catch" it visually. Now the top and bottom spacing is smaller than before.
Before:
After: