Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add box shadow to form messages #810

Merged
merged 2 commits into from Mar 29, 2020
Merged

Conversation

JKMarkowski
Copy link
Contributor

Related Issue

Closes #785

Description

There is theming parameter for shadow added for form messages.

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

Before:

image

After:

image

@JKMarkowski JKMarkowski requested a review from a team March 27, 2020 10:56
@JKMarkowski JKMarkowski added this to the Sprint 33 - London milestone Mar 27, 2020
@netlify
Copy link

netlify bot commented Mar 27, 2020

Deploy preview for fundamental-styles ready!

Built with commit 08c12f8

https://deploy-preview-810--fundamental-styles.netlify.com

@stefanoScalzo
Copy link
Contributor

the thing is the shadow looks like it has a border which doesn't look the same as ui5

@droshev droshev added this to PRs Reviewer approved in Development via automation Mar 29, 2020
@droshev droshev merged commit be2ee89 into master Mar 29, 2020
Development automation moved this from PRs Reviewer approved to Done Mar 29, 2020
@droshev droshev deleted the fix/form-popup-message-shadow branch March 29, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Fiori 3 Design Review: Form popup message should have box shadow
3 participants